The Terleckas Script

The Self-Documenting Column

apps/wms-platform/src/Picklist/Repository/PicklistLineRepository.php · on master 6 → 20 Jan 2023

SUM(picklist_line.requiredQuantity) as aggregatedRequired,
SUM(picklist_line.scannedQuantity)  as aggregatedScanned,
SUM(picklist_line.manuallyScannedQuantity) as
  aggregatedScannedQuantityThatIHAveToChangeToScanInQuantity,

A 57-character DQL alias that is not a name — it is a note to self, escaped into the type system, complete with a stray capital A in IHAve. It shipped to master and sat in production queries for fourteen days.

And then he did it. Commit 68abee1c, 20 January 2023: the alias is gone and the column is scanInQuantity. The identifier made a promise and the man kept it. This is, genuinely, the most Jonas artefact in the repository.

The Shouty TODO

Same file, four days later · 10 Jan 2023

// TODO: intro scanin scan and sort by it
// TODO: adjust tests, add cases
// TODO !!! AND SUM IS NOT YET PICKED !!!group b

Three TODOs stacked on one query builder, the last one shouting in capitals and trailing off mid-thought into group b. The commit that added it also replaced a bare // TODO: — a colon with nothing after it — so this counts as an improvement.

The Sleeping Suite

apps/wms-regression-tests · 42 sleep() calls, 94 seconds, all his

WebAppManager.php   16 sleeps
GoodsReceiptTest    6
PickerIsThePacker   7
…and, at line 1000:
// for animation to complete
sleep(2);

The end-to-end suite is held together by ninety-four seconds of hoping. One of them is documented, and its justification is a CSS transition.

The Plus Button

WebAppManager.php:955 · executeManualPickScript()

$selectedQuantity = 0;
while ($requiredQuantity > $selectedQuantity) {
    $this->logger->log('Clicking +');
    $this->webAppManagerClient->clickItem(PLUS_BUTTON);
    sleep(2);
    $selectedQuantity++;
}

To pick ten units, the test clicks + ten times and waits two seconds after each one. Twenty seconds, plus logging, to enter the number 10. There is a quantity input on that modal.

The Eleven Divs

apps/wms-regression-tests/src/RegressionTests/PageObject.php:241 · 65 of the file’s 86 locators are his

PIP_DROPDOWN_FIRST_SELECTION_LOCATOR =
  '//*[@id="app"]/div[1]/div[4]/div/div/div[1]/div/div/ul/li'

RETURNS_MODAL_NEXT_BUTTON_LOCATOR =
  '//*[@id="modal_root"]/div[2]/div/div/div[4]/button[2]'

Eleven levels of positional XPath, anchored to nothing but the shape of the DOM on the day it was written. Any frontend developer adding a wrapper div breaks the warehouse.

This is not hypothetical: 102 of his commits mention a selector or a locator. Nine are titled “Selector adjustments.” Seven are “Adjust selector.” Six, “Adjusting selectors.” Five, “Adjusting locators.”

The File That Was Excused

PageObject.php:22 — line 22 of 243

// phpcs:ignoreFile
final class PageObject
{

The coding standard is non-negotiable across the monorepo. Except here, where the very first statement after the namespace declaration is a note excusing the entire file from having to comply.

The Critical Public Key

branch JWT-debug · apps/wms-platform/common/src/Infrastructure/Security/WmsAuthenticator.php · 4–6 Sep 2023

public function doAuthenticate(Request $request): Passport
{
    $this->logger->critical("Debug JWT: \n" . $this->publicKey);

    return parent::doAuthenticate($request);
}

Every single authentication, dumping the key into the log at critical. When the log did not appear, the fix was to escalate the severity from error to critical and try again. Two days later it was reverted three times in seven minutes, across two repositories.

In his defence, and it is a real defence: it was the public key, and the branch never reached master.

WebAppManager

1,154 lines · 58 methods · one class · 2,325 lines of it written by him

selectApp()              scanItem()         completeDelivery()
selectStockMoveApp()     scanInItem()       completePicking()
selectBoxRange()         scanString()       completeScanIn()
selectPickingGroup()     scanGoodsReceipt() completePickToBox()
selectPicklist()         pickToBoxScanBox() completeBinRelocate()
…and 43 more

The largest hand-written file he touched, and the beating heart of the regression suite. Every warehouse workflow the company has, driven through one object. It is not good architecture. It has also been catching real bugs for four years, which is more than can be said for a lot of good architecture.